Fix #796 - Add ScheduleFile to MainRightColumnController#797
Merged
Conversation
jmarrec
added
Pull Request - Ready for CI
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #796 by adding support for Schedule File objects in the MainRightColumnController.
- Adds Schedule File type entries to model and library lists in several sub-tab configuration functions (Schedules, Loads, SpaceTypes, Facility, Spaces, ThermalZones, and HVACSystems).
- Ensures that Schedule File objects are available in the user interface for consistent object type handling.
Comments suppressed due to low confidence (1)
src/openstudio_lib/MainRightColumnController.cpp:248
- [nitpick] Consider extracting the repeated addition of the 'Schedule File' object type into a helper function or constant to improve maintainability and reduce code duplication across the different configuration methods.
myModelList->addModelObjectType(IddObjectType::OS_Schedule_File, "Schedule File");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.